jackwener commented on code in PR #23940: URL: https://github.com/apache/doris/pull/23940#discussion_r1316679085
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/OrToIn.java: ########## @@ -57,7 +55,7 @@ * adding any additional rule-specific fields to the default ExpressionRewriteContext. However, the entire expression * rewrite framework always passes an ExpressionRewriteContext of type context to all rules. */ -public class OrToIn extends DefaultExpressionRewriter<OrToInContext> implements +public class OrToIn extends DefaultExpressionRewriter<ExpressionRewriteContext> implements Review Comment: `OrToInContext` is useless? Can we remove it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
