[GitHub] [doris] yiguolei commented on a diff in pull request #23943: [chore](thirdparty)We need to issue an error when starting FE without setting the Java home environment

[via GitHub]

yiguolei commented on code in PR #23943:
URL: https://github.com/apache/doris/pull/23943#discussion_r1316574448


##########
bin/start_fe.sh:
##########
@@ -108,7 +108,12 @@ if [[ -e "${DORIS_HOME}/bin/palo_env.sh" ]]; then
 fi
 
 if [[ -z "${JAVA_HOME}" ]]; then
-    JAVA="$(command -v java)"
+    if ! command -v java &>/dev/null; then

Review Comment:
   please add some comment here， why do we need write code like this.
   Or the other developer may refactor code and rewrite this code.



##########
bin/start_fe.sh:
##########
@@ -108,7 +108,12 @@ if [[ -e "${DORIS_HOME}/bin/palo_env.sh" ]]; then
 fi
 
 if [[ -z "${JAVA_HOME}" ]]; then
-    JAVA="$(command -v java)"
+    if ! command -v java &>/dev/null; then

Review Comment:
   please add some comment here， why do we need write code like this.
   Or the other developer may refactor code and rewrite this code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org