This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 801ddc0313 [feature-wip](arrow-flight) BE not start Arrow Flight 
Service by default (#23901)
801ddc0313 is described below

commit 801ddc0313974dafebf1d10ec132f2923928b2bf
Author: Xinyi Zou <zouxiny...@gmail.com>
AuthorDate: Tue Sep 5 14:48:29 2023 +0800

    [feature-wip](arrow-flight) BE not start Arrow Flight Service by default 
(#23901)
---
 be/src/common/config.cpp                           | 2 +-
 be/src/common/config.h                             | 1 +
 be/src/service/arrow_flight/flight_sql_service.cpp | 4 ++++
 conf/be.conf                                       | 2 +-
 4 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/be/src/common/config.cpp b/be/src/common/config.cpp
index 41f608056d..0bac22880d 100644
--- a/be/src/common/config.cpp
+++ b/be/src/common/config.cpp
@@ -60,7 +60,7 @@ DEFINE_Int32(be_port, "9060");
 // port for brpc
 DEFINE_Int32(brpc_port, "8060");
 
-DEFINE_Int32(arrow_flight_port, "8070");
+DEFINE_Int32(arrow_flight_port, "-1");
 
 // the number of bthreads for brpc, the default value is set to -1,
 // which means the number of bthreads is #cpu-cores
diff --git a/be/src/common/config.h b/be/src/common/config.h
index 7bff893c78..d83e012719 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -97,6 +97,7 @@ DECLARE_Int32(be_port);
 DECLARE_Int32(brpc_port);
 
 // port for arrow flight
+// Default -1, do not start arrow flight server.
 DECLARE_Int32(arrow_flight_port);
 
 // the number of bthreads for brpc, the default value is set to -1,
diff --git a/be/src/service/arrow_flight/flight_sql_service.cpp 
b/be/src/service/arrow_flight/flight_sql_service.cpp
index d7cd307fe0..1bddedc4aa 100644
--- a/be/src/service/arrow_flight/flight_sql_service.cpp
+++ b/be/src/service/arrow_flight/flight_sql_service.cpp
@@ -98,6 +98,10 @@ 
arrow::Result<std::unique_ptr<arrow::flight::FlightDataStream>> FlightSqlServer:
 }
 
 Status FlightSqlServer::init(int port) {
+    if (port == -1) {
+        LOG(INFO) << "Arrow Flight Service not start";
+        return Status::OK();
+    }
     arrow::flight::Location bind_location;
     RETURN_DORIS_STATUS_IF_ERROR(
             
arrow::flight::Location::ForGrpcTcp(BackendOptions::get_service_bind_address(), 
port)
diff --git a/conf/be.conf b/conf/be.conf
index ae5f10d5b5..5077cc9f13 100644
--- a/conf/be.conf
+++ b/conf/be.conf
@@ -40,7 +40,7 @@ be_port = 9060
 webserver_port = 8040
 heartbeat_service_port = 9050
 brpc_port = 8060
-arrow_flight_port = 8070
+arrow_flight_port = -1
 
 # HTTPS configures
 enable_https = false


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to