zhannngchen commented on code in PR #23855:
URL: https://github.com/apache/doris/pull/23855#discussion_r1315407241
##########
be/src/olap/rowset/segment_v2/binary_prefix_page.cpp:
##########
@@ -215,7 +216,10 @@ Status BinaryPrefixPageDecoder::next_batch(size_t* n,
vectorized::MutableColumnP
// read and copy values
for (size_t i = 0; i < max_fetch; ++i) {
dst->insert_data((char*)(_current_value.data()),
_current_value.size());
- _read_next_value();
+ if (_next_ptr >= _footer_start) {
Review Comment:
While `i` < `max_fetch`, `_next_ptr` should not reach the position of
`_footer_start`？
In the other word, when `_next_ptr` reached the position of `_footer_start`,
`max_fetch` should be zero, or `i` would be equal with `max_fetch`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
