xiaokang commented on code in PR #23779:
URL: https://github.com/apache/doris/pull/23779#discussion_r1314917440
##########
be/src/vec/olap/olap_data_convertor.cpp:
##########
@@ -1011,8 +1011,8 @@ Status
OlapBlockDataConvertor::OlapColumnDataConvertorMap::convert_to_olap(
auto elem_size = end_offset - start_offset;
_offsets.clear();
- _offsets.reserve(_num_rows);
- for (int i = 0; i < _num_rows; ++i) {
+ _offsets.reserve(_num_rows + 1);
+ for (int i = 0; i <= _num_rows; ++i) {
Review Comment:
add comment to explain why add an extra offset
##########
be/src/olap/rowset/segment_v2/column_writer.cpp:
##########
@@ -731,6 +731,47 @@ Status ScalarColumnWriter::finish_current_page() {
////////////////////////////////////////////////////////////////////////////////
+////////////////////////////////////////////////////////////////////////////////
+// offset column writer
+////////////////////////////////////////////////////////////////////////////////
+
+OffsetColumnWriter::OffsetColumnWriter(const ColumnWriterOptions& opts,
+ std::unique_ptr<Field> field,
io::FileWriter* file_writer)
+ : ScalarColumnWriter(opts, std::move(field), file_writer) {
+ // now we only explain data in offset column as uint64
+ DCHECK(field->type() == FieldType::OLAP_FIELD_TYPE_UNSIGNED_BIGINT);
+}
+
+OffsetColumnWriter::~OffsetColumnWriter() = default;
+
+Status OffsetColumnWriter::init() {
+ RETURN_IF_ERROR(ScalarColumnWriter::init());
+ register_flush_page_callback(this);
+ _next_offset = 0;
+ return Status::OK();
+}
+
+Status OffsetColumnWriter::append_data(const uint8_t** ptr, size_t num_rows) {
+ size_t remaining = num_rows;
+ while (remaining > 0) {
+ size_t num_written = remaining;
+ RETURN_IF_ERROR(append_data_in_current_page(ptr, &num_written));
+ _next_offset = *(const uint64_t*)(*ptr);
Review Comment:
add comment to explain why get offset from *ptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
