liaoxin01 commented on code in PR #23681:
URL: https://github.com/apache/doris/pull/23681#discussion_r1314614250
##########
be/src/olap/merger.cpp:
##########
@@ -257,6 +274,11 @@ Status Merger::vertical_compact_one_group(
output_rows += block.rows();
block.clear_column_data();
}
+ if (is_key && reader_params.record_rowids > 0) {
+ RETURN_IF_ERROR(stats_output->rowid_conversion->save_to_file());
Review Comment:
We can add a configuration to control persistence only when the memory used
for rowid conversion exceeds the threshold.
##########
be/src/olap/rowid_conversion.h:
##########
@@ -130,6 +208,12 @@ class RowIdConversion {
// current rowid of dst segment
std::uint32_t _cur_dst_segment_rowid = 0;
+
+ std::string _file_name;
+ io::FileWriterPtr _file_writer;
+ io::FileReaderSPtr file_reader;
Review Comment:
file_reader -> _file_reader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
