xzj7019 commented on code in PR #23754:
URL: https://github.com/apache/doris/pull/23754#discussion_r1314383180
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java:
##########
@@ -60,20 +62,34 @@ public static boolean couldBroadcast(Join join) {
return !(join.getJoinType().isRightJoin() ||
join.getJoinType().isFullOuterJoin());
}
- private static final class JoinSlotCoverageChecker {
+ /**
Review Comment:
pls add this into case track
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java:
##########
@@ -60,20 +62,34 @@ public static boolean couldBroadcast(Join join) {
return !(join.getJoinType().isRightJoin() ||
join.getJoinType().isFullOuterJoin());
}
- private static final class JoinSlotCoverageChecker {
+ /**
+ * for a given expr, if expr is nullable, add 'expr is not null' in to
container.
+ * this is used to eliminate outer join.
+ * for example: (A left join B on A.a=B.b) join C on B.x=C.x
Review Comment:
could we just add InferJoinNotNull around EliminateOuterJoin rule to resolve
this problem autometiclly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
