xiaokang commented on code in PR #23779:
URL: https://github.com/apache/doris/pull/23779#discussion_r1313720186
##########
be/src/olap/rowset/segment_v2/column_writer.cpp:
##########
@@ -530,7 +530,12 @@ Status ScalarColumnWriter::append_data(const uint8_t**
ptr, size_t num_rows) {
remaining -= num_written;
if (_page_builder->is_page_full()) {
- RETURN_IF_ERROR(finish_current_page());
+ // get next data for next array_item_rowid
+ if (remaining == 0) {
+ RETURN_IF_ERROR(finish_current_page());
+ } else {
+ RETURN_IF_ERROR(finish_current_page(*ptr));
Review Comment:
It's very tricky to use *ptr as next offset. It can be used to verify the
bug, but not suitable for production code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
