zddr commented on code in PR #23682:
URL: https://github.com/apache/doris/pull/23682#discussion_r1313710931
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -936,7 +933,11 @@ public Partition dropPartition(long dbId, String
partitionName, boolean isForceD
// get partition by name, not including temp partitions
@Override
public Partition getPartition(String partitionName) {
Review Comment:
BindSink. bindPartitionIds will convert partition name to partition id by
calling this method，`OlapTable.getPartition(long partitionId)` has the same
change , now I change the comment of two method
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -936,7 +933,11 @@ public Partition dropPartition(long dbId, String
partitionName, boolean isForceD
// get partition by name, not including temp partitions
@Override
public Partition getPartition(String partitionName) {
Review Comment:
BindSink. bindPartitionIds will convert partition name to partition id by
calling this method，`OlapTable.getPartition(long partitionId)` has the same
change , now I change the comment of two method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
