airborne12 commented on code in PR #23581:
URL: https://github.com/apache/doris/pull/23581#discussion_r1312421965
##########
be/src/olap/like_column_predicate.cpp:
##########
@@ -83,18 +91,18 @@ uint16_t LikeColumnPredicate::evaluate(const
vectorized::IColumn& column, uint16
}
}
} else {
- auto* str_col =
-
vectorized::check_and_get_column<vectorized::PredicateColumnType<TYPE_STRING>>(
- nested_col);
+ auto* str_col =
vectorized::check_and_get_column<vectorized::PredicateColumnType<T>>(
+ nested_col);
if (!nullable_col->has_null()) {
vectorized::ColumnUInt8::Container res(size, 0);
- (_state->predicate_like_function)(
Review Comment:
in predicate function, substring is also processed in for loop:
`
Status FunctionLikeBase::constant_substring_fn_predicate(
LikeSearchState* state, const PredicateColumnType<TYPE_STRING>& val,
const StringRef& pattern, ColumnUInt8::Container& result, const
uint16_t* sel, size_t sz) {
auto data_ptr = reinterpret_cast<const
StringRef*>(val.get_data().data());
for (size_t i = 0; i < sz; i++) {
if (state->search_string_sv.size == 0) {
result[i] = true;
}
result[i] = state->substring_pattern.search(data_ptr[sel[i]]) !=
-1;
}
return Status::OK();
}
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
