github-actions[bot] commented on PR #23724:
URL: https://github.com/apache/doris/pull/23724#issuecomment-1701075079
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/6038218247";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In tools/ssb-tools/bin/create-ssb-tables.sh line 94:
if [ -z "${PASSWORD}" ];then
^------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
Did you mean:
if [[ -z "${PASSWORD}" ]];then
In tools/ssb-tools/bin/create-ssb-tables.sh line 96:
exec_clt="mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB "
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
^-^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
exec_clt="mysql -vvv -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
In tools/ssb-tools/bin/create-ssb-tables.sh line 99:
exec_clt="mysql -vvv -h$FE_HOST -u$USER -p${PASSWORD} -P$FE_QUERY_PORT
-D$DB "
^------^ SC2034 (warning): exec_clt appears unused. Verify use (or
export if used externally).
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
^-^ SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
exec_clt="mysql -vvv -h${FE_HOST} -u${USER} -p${PASSWORD}
-P${FE_QUERY_PORT} -D${DB} "
In tools/ssb-tools/bin/create-ssb-tables.sh line 107:
$clt -e "CREATE DATABASE IF NOT EXISTS ${DB}"
^--^ SC2250 (style): Prefer putting braces around variable references even
when not strictly required.
Did you mean:
${clt} -e "CREATE DATABASE IF NOT EXISTS ${DB}"
In tools/ssb-tools/bin/create-ssb-tables.sh line 110:
$clt < "${SSB_DDL}"
^--^ SC2250 (style): Prefer putting braces around variable references even
when not strictly required.
Did you mean:
${clt} < "${SSB_DDL}"
In tools/ssb-tools/bin/create-ssb-tables.sh line 113:
$clt < "${SSB_FLAT_DDL}"
^--^ SC2250 (style): Prefer putting braces around variable references even
when not strictly required.
Did you mean:
${clt} < "${SSB_FLAT_DDL}"
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 98:
touch $CURDIR/../ssb_flat_query_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
touch "${CURDIR}"/../ssb_flat_query_result.csv
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 99:
truncate -s0 $CURDIR/../ssb_flat_query_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
truncate -s0 "${CURDIR}"/../ssb_flat_query_result.csv
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 103:
if [ -z "${PASSWORD}" ];then
^------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
Did you mean:
if [[ -z "${PASSWORD}" ]];then
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 105:
exec_clt="mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB "
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
^-^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
exec_clt="mysql -vvv -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 108:
exec_clt="mysql -vvv -h$FE_HOST -u$USER -p${PASSWORD} -P$FE_QUERY_PORT
-D$DB "
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
^-^ SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
exec_clt="mysql -vvv -h${FE_HOST} -u${USER} -p${PASSWORD}
-P${FE_QUERY_PORT} -D${DB} "
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 113:
$clt -e "$@"
^--^ SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
Did you mean:
${clt} -e "$@"
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 153:
echo -n "q${i}.sql:" | tee -a $CURDIR/../ssb_flat_query_result.csv
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
echo -n "q${i}.sql:" | tee -a "${CURDIR}"/../ssb_flat_query_result.csv
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 155:
for ord in $(seq 1 $TRIES); do
^----^ SC2248 (style): Prefer double quoting even
when variables don't contain special characters.
^----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
for ord in $(seq 1 "${TRIES}"); do
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 159:
sum=$(echo "$sum + $number" | bc)
^--^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
sum=$(echo "${sum} + ${number}" | bc)
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 160:
done <<< "$res"
^--^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
done <<< "${res}"
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 161:
if [ $ord -eq 1 ];then
^------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
^--^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^--^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ "${ord}" -eq 1 ]];then
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 162:
runtime=$(echo "scale=6;0.0000+$sum" | bc)
^--^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
runtime=$(echo "scale=6;0.0000+${sum}" | bc)
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 164:
if [ $( echo "$runtime > $sum" | bc ) -eq 1 ];then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^-- SC2046 (warning): Quote this to prevent word splitting.
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^--^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
if [[ $( echo "${runtime} > ${sum}" | bc ) -eq 1 ]];then
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 165:
runtime=$(echo "scale=6;0.0000+$sum" | bc)
^--^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
runtime=$(echo "scale=6;0.0000+${sum}" | bc)
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 170:
echo -n "${runtime}" | tee -a $CURDIR/../ssb_flat_query_result.csv
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
echo -n "${runtime}" | tee -a "${CURDIR}"/../ssb_flat_query_result.csv
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 171:
echo "" | tee -a $CURDIR/../ssb_flat_query_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing
and word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../ssb_flat_query_result.csv
In tools/ssb-tools/bin/exec-ssb-flat-queries.sh line 173:
total_time=$(echo "scale=6;$total_time+$runtime" | bc)
^---------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
total_time=$(echo "scale=6;${total_time}+${runtime}" | bc)
In tools/ssb-tools/bin/exec-ssb-queries.sh line 98:
touch $CURDIR/../ssb_query_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
touch "${CURDIR}"/../ssb_query_result.csv
In tools/ssb-tools/bin/exec-ssb-queries.sh line 99:
truncate -s0 $CURDIR/../ssb_query_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
truncate -s0 "${CURDIR}"/../ssb_query_result.csv
In tools/ssb-tools/bin/exec-ssb-queries.sh line 103:
if [ -z "${PASSWORD}" ];then
^------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
Did you mean:
if [[ -z "${PASSWORD}" ]];then
In tools/ssb-tools/bin/exec-ssb-queries.sh line 105:
exec_clt="mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB "
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
^-^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
exec_clt="mysql -vvv -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
In tools/ssb-tools/bin/exec-ssb-queries.sh line 108:
exec_clt="mysql -vvv -h$FE_HOST -u$USER -p${PASSWORD} -P$FE_QUERY_PORT
-D$DB "
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
^-^ SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
exec_clt="mysql -vvv -h${FE_HOST} -u${USER} -p${PASSWORD}
-P${FE_QUERY_PORT} -D${DB} "
In tools/ssb-tools/bin/exec-ssb-queries.sh line 113:
$clt -e "$@"
^--^ SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
Did you mean:
${clt} -e "$@"
In tools/ssb-tools/bin/exec-ssb-queries.sh line 166:
echo -n "q${i}.sql:" | tee -a $CURDIR/../ssb_query_result.csv
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
echo -n "q${i}.sql:" | tee -a "${CURDIR}"/../ssb_query_result.csv
In tools/ssb-tools/bin/exec-ssb-queries.sh line 168:
for ord in $(seq 1 $TRIES); do
^----^ SC2248 (style): Prefer double quoting even
when variables don't contain special characters.
^----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
for ord in $(seq 1 "${TRIES}"); do
In tools/ssb-tools/bin/exec-ssb-queries.sh line 172:
sum=$(echo "$sum + $number" | bc)
^--^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
sum=$(echo "${sum} + ${number}" | bc)
In tools/ssb-tools/bin/exec-ssb-queries.sh line 173:
done <<< "$res"
^--^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
done <<< "${res}"
In tools/ssb-tools/bin/exec-ssb-queries.sh line 174:
if [ $ord -eq 1 ];then
^------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
^--^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^--^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ "${ord}" -eq 1 ]];then
In tools/ssb-tools/bin/exec-ssb-queries.sh line 175:
runtime=$(echo "scale=6;0.0000+$sum" | bc)
^--^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
runtime=$(echo "scale=6;0.0000+${sum}" | bc)
In tools/ssb-tools/bin/exec-ssb-queries.sh line 177:
if [ $( echo "$runtime > $sum" | bc ) -eq 1 ];then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^-- SC2046 (warning): Quote this to prevent word splitting.
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^--^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
if [[ $( echo "${runtime} > ${sum}" | bc ) -eq 1 ]];then
In tools/ssb-tools/bin/exec-ssb-queries.sh line 178:
runtime=$(echo "scale=6;0.0000+$sum" | bc)
^--^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
runtime=$(echo "scale=6;0.0000+${sum}" | bc)
In tools/ssb-tools/bin/exec-ssb-queries.sh line 183:
echo -n "${runtime}" | tee -a $CURDIR/../ssb_query_result.csv
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
echo -n "${runtime}" | tee -a "${CURDIR}"/../ssb_query_result.csv
In tools/ssb-tools/bin/exec-ssb-queries.sh line 184:
echo "" | tee -a $CURDIR/../ssb_query_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing
and word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../ssb_query_result.csv
In tools/ssb-tools/bin/exec-ssb-queries.sh line 186:
total_time=$(echo "scale=6;$total_time+$runtime" | bc)
^---------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
total_time=$(echo "scale=6;${total_time}+${runtime}" | bc)
In tools/ssb-tools/bin/load-ssb-data.sh line 34:
source $CURDIR/../conf/cluster.conf
^-----^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
source "${CURDIR}"/../conf/cluster.conf
In tools/ssb-tools/bin/load-ssb-data.sh line 36:
if [ "_${SSB_DATA_DIR}" == "_ssb-data" ];then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
Did you mean:
if [[ "_${SSB_DATA_DIR}" == "_ssb-data" ]];then
In tools/ssb-tools/bin/load-ssb-data.sh line 37:
SSB_DATA_DIR="$CURDIR/../bin/${DATA_SAVE_DIR}"
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
SSB_DATA_DIR="${CURDIR}/../bin/${DATA_SAVE_DIR}"
In tools/ssb-tools/bin/load-ssb-data.sh line 112:
if [ -z "${PASSWORD}" ];then
^------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
Did you mean:
if [[ -z "${PASSWORD}" ]];then
In tools/ssb-tools/bin/load-ssb-data.sh line 121:
$clt -e "$@"
^--^ SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
Did you mean:
${clt} -e "$@"
In tools/ssb-tools/bin/load-ssb-data.sh line 218:
touch $CURDIR/../ssb_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
touch "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 219:
truncate -s0 $CURDIR/../ssb_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
truncate -s0 "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 220:
touch $CURDIR/../ssb_flat_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
touch "${CURDIR}"/../ssb_flat_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 221:
truncate -s0 $CURDIR/../ssb_flat_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
truncate -s0 "${CURDIR}"/../ssb_flat_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 233:
cost_time=$(echo "scale=4;$part_end-$part_start" | bc)
^-------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
cost_time=$(echo "scale=4;${part_end}-${part_start}" | bc)
In tools/ssb-tools/bin/load-ssb-data.sh line 234:
echo -n "part_stream_load:" | tee -a $CURDIR/../ssb_load_result.csv
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
echo -n "part_stream_load:" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 235:
echo -n "$cost_time" | tee -a $CURDIR/../ssb_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 236:
echo "" | tee -a $CURDIR/../ssb_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 245:
cost_time=$(echo "scale=4;$dates_end-$dates_start" | bc)
^--------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^----------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
cost_time=$(echo "scale=4;${dates_end}-${dates_start}" | bc)
In tools/ssb-tools/bin/load-ssb-data.sh line 246:
echo -n "dates_stream_load:" | tee -a $CURDIR/../ssb_load_result.csv
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
echo -n "dates_stream_load:" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 247:
echo -n "$cost_time" | tee -a $CURDIR/../ssb_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 248:
echo "" | tee -a $CURDIR/../ssb_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 257:
cost_time=$(echo "scale=4;$supplier_end-$supplier_start" | bc)
^-----------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^-------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
cost_time=$(echo "scale=4;${supplier_end}-${supplier_start}" | bc)
In tools/ssb-tools/bin/load-ssb-data.sh line 258:
echo -n "supplier_stream_load:" | tee -a $CURDIR/../ssb_load_result.csv
^-----^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
echo -n "supplier_stream_load:" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 259:
echo -n "$cost_time" | tee -a $CURDIR/../ssb_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 260:
echo "" | tee -a $CURDIR/../ssb_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 269:
cost_time=$(echo "scale=4;$customer_end-$customer_start" | bc)
^-----------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^-------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
cost_time=$(echo "scale=4;${customer_end}-${customer_start}" | bc)
In tools/ssb-tools/bin/load-ssb-data.sh line 270:
echo -n "customer_stream_load:" | tee -a $CURDIR/../ssb_load_result.csv
^-----^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
echo -n "customer_stream_load:" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 271:
echo -n "$cost_time" | tee -a $CURDIR/../ssb_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 272:
echo "" | tee -a $CURDIR/../ssb_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 305:
cost_time=$(echo "scale=4;$lineorder_end-$lineorder_start" | bc)
^------------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^--------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
cost_time=$(echo "scale=4;${lineorder_end}-${lineorder_start}" | bc)
In tools/ssb-tools/bin/load-ssb-data.sh line 306:
echo -n "lineorder_stream_load:" | tee -a $CURDIR/../ssb_load_result.csv
^-----^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
echo -n "lineorder_stream_load:" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 307:
echo -n "$cost_time" | tee -a $CURDIR/../ssb_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 308:
echo "" | tee -a $CURDIR/../ssb_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../ssb_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 326:
cost_time=$(echo "scale=4;$lineitem_flat_end-$lineitem_flat_start" | bc)
^----------------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------------^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
cost_time=$(echo "scale=4;${lineitem_flat_end}-${lineitem_flat_start}" | bc)
In tools/ssb-tools/bin/load-ssb-data.sh line 327:
echo -n "lineitem_flat_insert_into:" | tee -a
$CURDIR/../ssb_flat_load_result.csv
^-----^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
echo -n "lineitem_flat_insert_into:" | tee -a
"${CURDIR}"/../ssb_flat_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 328:
echo -n "$cost_time" | tee -a $CURDIR/../ssb_flat_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../ssb_flat_load_result.csv
In tools/ssb-tools/bin/load-ssb-data.sh line 329:
echo "" | tee -a $CURDIR/../ssb_flat_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../ssb_flat_load_result.csv
In tools/tpch-tools/bin/create-tpch-tables.sh line 91:
if [ -z "${PASSWORD}" ];then
^------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
Did you mean:
if [[ -z "${PASSWORD}" ]];then
In tools/tpch-tools/bin/create-tpch-tables.sh line 93:
exec_clt="mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB "
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
^-^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
exec_clt="mysql -vvv -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
In tools/tpch-tools/bin/create-tpch-tables.sh line 96:
exec_clt="mysql -vvv -h$FE_HOST -u$USER -p${PASSWORD} -P$FE_QUERY_PORT
-D$DB "
^------^ SC2034 (warning): exec_clt appears unused. Verify use (or
export if used externally).
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
^-^ SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
exec_clt="mysql -vvv -h${FE_HOST} -u${USER} -p${PASSWORD}
-P${FE_QUERY_PORT} -D${DB} "
In tools/tpch-tools/bin/create-tpch-tables.sh line 105:
$clt -e "CREATE DATABASE IF NOT EXISTS ${DB}"
^--^ SC2250 (style): Prefer putting braces around variable references even
when not strictly required.
Did you mean:
${clt} -e "CREATE DATABASE IF NOT EXISTS ${DB}"
In tools/tpch-tools/bin/create-tpch-tables.sh line 108:
$clt <"${CURDIR}"/../ddl/create-tpch-tables.sql
^--^ SC2250 (style): Prefer putting braces around variable references even
when not strictly required.
Did you mean:
${clt} <"${CURDIR}"/../ddl/create-tpch-tables.sql
In tools/tpch-tools/bin/exec-tpch-queries.sh line 95:
touch $CURDIR/../tpch_query_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
touch "${CURDIR}"/../tpch_query_result.csv
In tools/tpch-tools/bin/exec-tpch-queries.sh line 96:
truncate -s0 $CURDIR/../tpch_query_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
truncate -s0 "${CURDIR}"/../tpch_query_result.csv
In tools/tpch-tools/bin/exec-tpch-queries.sh line 100:
if [ -z "${PASSWORD}" ];then
^------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
Did you mean:
if [[ -z "${PASSWORD}" ]];then
In tools/tpch-tools/bin/exec-tpch-queries.sh line 102:
exec_clt="mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB "
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
^-^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
exec_clt="mysql -vvv -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
In tools/tpch-tools/bin/exec-tpch-queries.sh line 105:
exec_clt="mysql -vvv -h$FE_HOST -u$USER -p${PASSWORD} -P$FE_QUERY_PORT
-D$DB "
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
^-^ SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
exec_clt="mysql -vvv -h${FE_HOST} -u${USER} -p${PASSWORD}
-P${FE_QUERY_PORT} -D${DB} "
In tools/tpch-tools/bin/exec-tpch-queries.sh line 111:
$clt -e "$*"
^--^ SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
Did you mean:
${clt} -e "$*"
In tools/tpch-tools/bin/exec-tpch-queries.sh line 141:
echo -n "q${i}.sql:" | tee -a $CURDIR/../tpch_query_result.csv
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
echo -n "q${i}.sql:" | tee -a "${CURDIR}"/../tpch_query_result.csv
In tools/tpch-tools/bin/exec-tpch-queries.sh line 144:
for ord in $(seq 1 $TRIES); do
^----^ SC2248 (style): Prefer double quoting even
when variables don't contain special characters.
^----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
for ord in $(seq 1 "${TRIES}"); do
In tools/tpch-tools/bin/exec-tpch-queries.sh line 148:
sum=$(echo "$sum + $number" | bc)
^--^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
sum=$(echo "${sum} + ${number}" | bc)
In tools/tpch-tools/bin/exec-tpch-queries.sh line 149:
done <<< "$res"
^--^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
done <<< "${res}"
In tools/tpch-tools/bin/exec-tpch-queries.sh line 150:
if [ $ord -eq 1 ];then
^------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
^--^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^--^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ "${ord}" -eq 1 ]];then
In tools/tpch-tools/bin/exec-tpch-queries.sh line 151:
runtime=$(echo "scale=6;0.0000+$sum" | bc)
^--^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
runtime=$(echo "scale=6;0.0000+${sum}" | bc)
In tools/tpch-tools/bin/exec-tpch-queries.sh line 153:
if [ $( echo "$runtime > $sum" | bc ) -eq 1 ];then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^-- SC2046 (warning): Quote this to prevent word splitting.
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^--^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
if [[ $( echo "${runtime} > ${sum}" | bc ) -eq 1 ]];then
In tools/tpch-tools/bin/exec-tpch-queries.sh line 154:
runtime=$(echo "scale=6;0.0000+$sum" | bc)
^--^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
runtime=$(echo "scale=6;0.0000+${sum}" | bc)
In tools/tpch-tools/bin/exec-tpch-queries.sh line 159:
echo -n "${runtime}" | tee -a $CURDIR/../tpch_query_result.csv
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
echo -n "${runtime}" | tee -a "${CURDIR}"/../tpch_query_result.csv
In tools/tpch-tools/bin/exec-tpch-queries.sh line 160:
echo "" | tee -a $CURDIR/../tpch_query_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing
and word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../tpch_query_result.csv
In tools/tpch-tools/bin/exec-tpch-queries.sh line 162:
total_time=$(echo "scale=6;$total_time+$runtime" | bc)
^---------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
total_time=$(echo "scale=6;${total_time}+${runtime}" | bc)
In tools/tpch-tools/bin/load-tpch-data.sh line 33:
source $CURDIR/../conf/cluster.conf
^-----^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
source "${CURDIR}"/../conf/cluster.conf
In tools/tpch-tools/bin/load-tpch-data.sh line 35:
if [ "_${TPCH_DATA_DIR}" == "_tpch-data" ];then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
Did you mean:
if [[ "_${TPCH_DATA_DIR}" == "_tpch-data" ]];then
In tools/tpch-tools/bin/load-tpch-data.sh line 36:
TPCH_DATA_DIR="$CURDIR/../bin/${DATA_SAVE_DIR}"
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
TPCH_DATA_DIR="${CURDIR}/../bin/${DATA_SAVE_DIR}"
In tools/tpch-tools/bin/load-tpch-data.sh line 121:
touch $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
touch "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 122:
truncate -s0 $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
truncate -s0 "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 126:
if [ -z "${PASSWORD}" ];then
^------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
Did you mean:
if [[ -z "${PASSWORD}" ]];then
In tools/tpch-tools/bin/load-tpch-data.sh line 128:
exec_clt="mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB "
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
^-^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
exec_clt="mysql -vvv -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
In tools/tpch-tools/bin/load-tpch-data.sh line 131:
exec_clt="mysql -vvv -h$FE_HOST -u$USER -p${PASSWORD} -P$FE_QUERY_PORT
-D$DB "
^------^ SC2034 (warning): exec_clt appears unused. Verify use (or
export if used externally).
^------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------------^
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
^-^ SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
exec_clt="mysql -vvv -h${FE_HOST} -u${USER} -p${PASSWORD}
-P${FE_QUERY_PORT} -D${DB} "
In tools/tpch-tools/bin/load-tpch-data.sh line 136:
$clt -e "$*"
^--^ SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
Did you mean:
${clt} -e "$*"
In tools/tpch-tools/bin/load-tpch-data.sh line 204:
cost_time=$(echo "scale=4;$region_end-$region_start" | bc)
^---------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^-----------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
cost_time=$(echo "scale=4;${region_end}-${region_start}" | bc)
In tools/tpch-tools/bin/load-tpch-data.sh line 205:
echo -n "region_stream_load:" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
echo -n "region_stream_load:" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 206:
echo -n "$cost_time" | tee -a $CURDIR/../tpch_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 207:
echo "" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 212:
cost_time=$(echo "scale=4;$nation_end-$nation_start" | bc)
^---------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^-----------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
cost_time=$(echo "scale=4;${nation_end}-${nation_start}" | bc)
In tools/tpch-tools/bin/load-tpch-data.sh line 213:
echo -n "nation_stream_load:" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
echo -n "nation_stream_load:" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 214:
echo -n "$cost_time" | tee -a $CURDIR/../tpch_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 215:
echo "" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 220:
cost_time=$(echo "scale=4;$supplier_end-$supplier_start" | bc)
^-----------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^-------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
cost_time=$(echo "scale=4;${supplier_end}-${supplier_start}" | bc)
In tools/tpch-tools/bin/load-tpch-data.sh line 221:
echo -n "supplier_stream_load:" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
echo -n "supplier_stream_load:" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 222:
echo -n "$cost_time" | tee -a $CURDIR/../tpch_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 223:
echo "" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 228:
cost_time=$(echo "scale=4;$customer_end-$customer_start" | bc)
^-----------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^-------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
cost_time=$(echo "scale=4;${customer_end}-${customer_start}" | bc)
In tools/tpch-tools/bin/load-tpch-data.sh line 229:
echo -n "customer_stream_load:" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
echo -n "customer_stream_load:" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 230:
echo -n "$cost_time" | tee -a $CURDIR/../tpch_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 231:
echo "" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 236:
cost_time=$(echo "scale=4;$part_end-$part_start" | bc)
^-------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^---------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
cost_time=$(echo "scale=4;${part_end}-${part_start}" | bc)
In tools/tpch-tools/bin/load-tpch-data.sh line 237:
echo -n "part_stream_load:" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
echo -n "part_stream_load:" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 238:
echo -n "$cost_time" | tee -a $CURDIR/../tpch_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 239:
echo "" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 276:
cost_time=$(echo "scale=4;$lineitem_end-$lineitem_start" | bc)
^-----------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^-------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
cost_time=$(echo "scale=4;${lineitem_end}-${lineitem_start}" | bc)
In tools/tpch-tools/bin/load-tpch-data.sh line 277:
echo -n "lineitem_stream_load:" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
echo -n "lineitem_stream_load:" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 278:
echo -n "$cost_time" | tee -a $CURDIR/../tpch_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 279:
echo "" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 293:
cost_time=$(echo "scale=4;$orders_end-$orders_start" | bc)
^---------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^-----------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
cost_time=$(echo "scale=4;${orders_end}-${orders_start}" | bc)
In tools/tpch-tools/bin/load-tpch-data.sh line 294:
echo -n "orders_stream_load:" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
echo -n "orders_stream_load:" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 295:
echo -n "$cost_time" | tee -a $CURDIR/../tpch_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 296:
echo "" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 310:
cost_time=$(echo "scale=4;$partsupp_end-$partsupp_start" | bc)
^-----------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^-------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
cost_time=$(echo "scale=4;${partsupp_end}-${partsupp_start}" | bc)
In tools/tpch-tools/bin/load-tpch-data.sh line 311:
echo -n "partsupp_stream_load:" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^-----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
echo -n "partsupp_stream_load:" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 312:
echo -n "$cost_time" | tee -a $CURDIR/../tpch_load_result.csv
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
^-----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo -n "${cost_time}" | tee -a "${CURDIR}"/../tpch_load_result.csv
In tools/tpch-tools/bin/load-tpch-data.sh line 313:
echo "" | tee -a $CURDIR/../tpch_load_result.csv
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "" | tee -a "${CURDIR}"/../tpch_load_result.csv
For more information:
https://www.shellcheck.net/wiki/SC2034 -- exec_clt appears unused. Verify
u...
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word
splitt...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/ssb-tools/bin/create-ssb-tables.sh.orig
+++ tools/ssb-tools/bin/create-ssb-tables.sh
@@ -91,7 +91,7 @@
clt=""
exec_clt=""
-if [ -z "${PASSWORD}" ];then
+if [ -z "${PASSWORD}" ]; then
clt="mysql -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
exec_clt="mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB "
else
@@ -107,9 +107,9 @@
$clt -e "CREATE DATABASE IF NOT EXISTS ${DB}"
echo "Run DDL from ${SSB_DDL}"
-$clt < "${SSB_DDL}"
+$clt <"${SSB_DDL}"
echo "Run DDL from ${SSB_FLAT_DDL}"
-$clt < "${SSB_FLAT_DDL}"
+$clt <"${SSB_FLAT_DDL}"
echo "ssb tables has been created"
--- tools/ssb-tools/bin/exec-ssb-flat-queries.sh.orig
+++ tools/ssb-tools/bin/exec-ssb-flat-queries.sh
@@ -100,7 +100,7 @@
clt=""
exec_clt=""
-if [ -z "${PASSWORD}" ];then
+if [ -z "${PASSWORD}" ]; then
clt="mysql -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
exec_clt="mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB "
else
@@ -148,23 +148,23 @@
total_time=0
for i in '1.1' '1.2' '1.3' '2.1' '2.2' '2.3' '3.1' '3.2' '3.3' '3.4' '4.1'
'4.2' '4.3'; do
# Each query is executed four times, taking the best of the next three
- ${exec_clt} < "${QUERIES_DIR}/q${i}.sql" >/dev/null 2>&1
+ ${exec_clt} <"${QUERIES_DIR}/q${i}.sql" >/dev/null 2>&1
echo -n "q${i}.sql:" | tee -a $CURDIR/../ssb_flat_query_result.csv
runtime=0.0000
for ord in $(seq 1 $TRIES); do
- res=$(${exec_clt} < "${QUERIES_DIR}/q${i}.sql" | perl -nle 'print $1
if /\((\d+\.\d+)+ sec\)/' || :)
- sum=0.0000
- while IFS= read -r number; do
- sum=$(echo "$sum + $number" | bc)
- done <<< "$res"
- if [ $ord -eq 1 ];then
- runtime=$(echo "scale=6;0.0000+$sum" | bc)
- else
- if [ $( echo "$runtime > $sum" | bc ) -eq 1 ];then
- runtime=$(echo "scale=6;0.0000+$sum" | bc)
- fi
- fi
+ res=$(${exec_clt} <"${QUERIES_DIR}/q${i}.sql" | perl -nle 'print $1
if /\((\d+\.\d+)+ sec\)/' || :)
+ sum=0.0000
+ while IFS= read -r number; do
+ sum=$(echo "$sum + $number" | bc)
+ done <<<"$res"
+ if [ $ord -eq 1 ]; then
+ runtime=$(echo "scale=6;0.0000+$sum" | bc)
+ else
+ if [ $(echo "$runtime > $sum" | bc) -eq 1 ]; then
+ runtime=$(echo "scale=6;0.0000+$sum" | bc)
+ fi
+ fi
done
echo -n "${runtime}" | tee -a $CURDIR/../ssb_flat_query_result.csv
--- tools/ssb-tools/bin/exec-ssb-queries.sh.orig
+++ tools/ssb-tools/bin/exec-ssb-queries.sh
@@ -100,7 +100,7 @@
clt=""
exec_clt=""
-if [ -z "${PASSWORD}" ];then
+if [ -z "${PASSWORD}" ]; then
clt="mysql -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
exec_clt="mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB "
else
@@ -161,23 +161,23 @@
total_time=0
for i in '1.1' '1.2' '1.3' '2.1' '2.2' '2.3' '3.1' '3.2' '3.3' '3.4' '4.1'
'4.2' '4.3'; do
# Each query is executed four times, taking the best of the next three
- ${exec_clt} < "${QUERIES_DIR}/q${i}.sql" >/dev/null 2>&1
+ ${exec_clt} <"${QUERIES_DIR}/q${i}.sql" >/dev/null 2>&1
echo -n "q${i}.sql:" | tee -a $CURDIR/../ssb_query_result.csv
runtime=0.0000
for ord in $(seq 1 $TRIES); do
- res=$(${exec_clt} < "${QUERIES_DIR}/q${i}.sql" | perl -nle 'print $1
if /\((\d+\.\d+)+ sec\)/' || :)
- sum=0.0000
- while IFS= read -r number; do
- sum=$(echo "$sum + $number" | bc)
- done <<< "$res"
- if [ $ord -eq 1 ];then
- runtime=$(echo "scale=6;0.0000+$sum" | bc)
- else
- if [ $( echo "$runtime > $sum" | bc ) -eq 1 ];then
- runtime=$(echo "scale=6;0.0000+$sum" | bc)
- fi
- fi
+ res=$(${exec_clt} <"${QUERIES_DIR}/q${i}.sql" | perl -nle 'print $1
if /\((\d+\.\d+)+ sec\)/' || :)
+ sum=0.0000
+ while IFS= read -r number; do
+ sum=$(echo "$sum + $number" | bc)
+ done <<<"$res"
+ if [ $ord -eq 1 ]; then
+ runtime=$(echo "scale=6;0.0000+$sum" | bc)
+ else
+ if [ $(echo "$runtime > $sum" | bc) -eq 1 ]; then
+ runtime=$(echo "scale=6;0.0000+$sum" | bc)
+ fi
+ fi
done
echo -n "${runtime}" | tee -a $CURDIR/../ssb_query_result.csv
--- tools/ssb-tools/bin/load-ssb-data.sh.orig
+++ tools/ssb-tools/bin/load-ssb-data.sh
@@ -33,12 +33,11 @@
source $CURDIR/../conf/cluster.conf
SSB_DATA_DIR="${DATA_SAVE_DIR}"
-if [ "_${SSB_DATA_DIR}" == "_ssb-data" ];then
+if [ "_${SSB_DATA_DIR}" == "_ssb-data" ]; then
SSB_DATA_DIR="$CURDIR/../bin/${DATA_SAVE_DIR}"
fi
echo "SSB_DATA_DIR: ${SSB_DATA_DIR}"
-
usage() {
echo "
Usage: $0 <options>
@@ -109,7 +108,7 @@
}
clt=""
-if [ -z "${PASSWORD}" ];then
+if [ -z "${PASSWORD}" ]; then
clt="mysql -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
else
clt="mysql -h${FE_HOST} -u${USER} -p${PASSWORD} -P${FE_QUERY_PORT}
-D${DB} "
--- tools/ssb-tools/bin/run-all.sh.orig
+++ tools/ssb-tools/bin/run-all.sh
--- tools/tpch-tools/bin/create-tpch-tables.sh.orig
+++ tools/tpch-tools/bin/create-tpch-tables.sh
@@ -88,7 +88,7 @@
clt=""
exec_clt=""
-if [ -z "${PASSWORD}" ];then
+if [ -z "${PASSWORD}" ]; then
clt="mysql -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
exec_clt="mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB "
else
@@ -96,7 +96,6 @@
exec_clt="mysql -vvv -h$FE_HOST -u$USER -p${PASSWORD} -P$FE_QUERY_PORT
-D$DB "
fi
-
echo "FE_HOST: ${FE_HOST}"
echo "FE_QUERY_PORT: ${FE_QUERY_PORT}"
echo "USER: ${USER}"
--- tools/tpch-tools/bin/exec-tpch-queries.sh.orig
+++ tools/tpch-tools/bin/exec-tpch-queries.sh
@@ -97,7 +97,7 @@
clt=""
exec_clt=""
-if [ -z "${PASSWORD}" ];then
+if [ -z "${PASSWORD}" ]; then
clt="mysql -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
exec_clt="mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB "
else
@@ -105,7 +105,6 @@
exec_clt="mysql -vvv -h$FE_HOST -u$USER -p${PASSWORD} -P$FE_QUERY_PORT
-D$DB "
fi
-
run_sql() {
echo "$*"
$clt -e "$*"
@@ -142,18 +141,18 @@
runtime=0.0000
for ord in $(seq 1 $TRIES); do
- res=$(${exec_clt} < "${QUERIES_DIR}/q${i}.sql" | perl -nle 'print $1
if /\((\d+\.\d+)+ sec\)/' || :)
- sum=0.0000
- while IFS= read -r number; do
- sum=$(echo "$sum + $number" | bc)
- done <<< "$res"
- if [ $ord -eq 1 ];then
- runtime=$(echo "scale=6;0.0000+$sum" | bc)
- else
- if [ $( echo "$runtime > $sum" | bc ) -eq 1 ];then
- runtime=$(echo "scale=6;0.0000+$sum" | bc)
- fi
- fi
+ res=$(${exec_clt} <"${QUERIES_DIR}/q${i}.sql" | perl -nle 'print $1
if /\((\d+\.\d+)+ sec\)/' || :)
+ sum=0.0000
+ while IFS= read -r number; do
+ sum=$(echo "$sum + $number" | bc)
+ done <<<"$res"
+ if [ $ord -eq 1 ]; then
+ runtime=$(echo "scale=6;0.0000+$sum" | bc)
+ else
+ if [ $(echo "$runtime > $sum" | bc) -eq 1 ]; then
+ runtime=$(echo "scale=6;0.0000+$sum" | bc)
+ fi
+ fi
done
echo -n "${runtime}" | tee -a $CURDIR/../tpch_query_result.csv
--- tools/tpch-tools/bin/load-tpch-data.sh.orig
+++ tools/tpch-tools/bin/load-tpch-data.sh
@@ -32,7 +32,7 @@
CURDIR="${ROOT}"
source $CURDIR/../conf/cluster.conf
TPCH_DATA_DIR="${DATA_SAVE_DIR}"
-if [ "_${TPCH_DATA_DIR}" == "_tpch-data" ];then
+if [ "_${TPCH_DATA_DIR}" == "_tpch-data" ]; then
TPCH_DATA_DIR="$CURDIR/../bin/${DATA_SAVE_DIR}"
fi
echo "TPCH_DATA_DIR: ${TPCH_DATA_DIR}"
@@ -123,7 +123,7 @@
clt=""
exec_clt=""
-if [ -z "${PASSWORD}" ];then
+if [ -z "${PASSWORD}" ]; then
clt="mysql -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} "
exec_clt="mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB "
else
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
