yiguolei commented on code in PR #23659:
URL: https://github.com/apache/doris/pull/23659#discussion_r1310981463
##########
be/src/olap/page_cache.h:
##########
@@ -103,21 +103,22 @@ class StoragePageCache {
class DataPageCache : public LRUCachePolicy {
public:
DataPageCache(size_t capacity, uint32_t num_shards)
- : LRUCachePolicy("DataPageCache", capacity, LRUCacheType::SIZE,
+ : LRUCachePolicy(CachePolicy::Type::DATA_PAGE_CACHE, capacity,
LRUCacheType::SIZE,
Review Comment:
rename to CACHE_TYPE
CachePolicy::TYPE user may treat it as policy type. But actually, it is one
kind of cache, not one kink of policy like lru,fifio...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
