[GitHub] [doris] yiguolei commented on a diff in pull request #23672: [improvement](Block) Replace Block(const PBlock&) with deserialize because it has heavy operations in ctor

[via GitHub]

yiguolei commented on code in PR #23672:
URL: https://github.com/apache/doris/pull/23672#discussion_r1310073995


##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -436,9 +436,10 @@ Status TabletsChannel::add_batch(const 
PTabletWriterAddBlockRequest& request,
         }
     }
 
-    auto get_send_data = [&]() { return vectorized::Block(request.block()); };
+    vectorized::Block send_data;
+    auto get_send_data = [&]() { return 
send_data.deserialize(request.block()); };

Review Comment:
   should create a new block and then return it.
   if the get_send_data is called multiple times then it is wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org