github-actions[bot] commented on PR #23674: URL: https://github.com/apache/doris/pull/23674#issuecomment-1698879432
#### `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/6023486582") output. <details> <summary>shellcheck errors</summary> ``` 'shellcheck ' returned error 1 finding the following syntactical issues: ---------- In env.sh line 154: covs+=("$line") ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. Did you mean: covs+=("${line}") In env.sh line 166: profdatas+=("$line") ^-------^ SC2030 (info): Modification of profdatas is local (to subshell caused by pipeline). ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. Did you mean: profdatas+=("${line}") In env.sh line 168: if [[ ${#profdatas[@]} -ge 1 ]]; then ^--------------^ SC2031 (info): profdatas was modified in a subshell. That change might be lost. In env.sh line 169: LLVM_PROFDATA="${profdatas[0]}" ^-------------^ SC2031 (info): profdatas was modified in a subshell. That change might be lost. For more information: https://www.shellcheck.net/wiki/SC2030 -- Modification of profdatas is loca... https://www.shellcheck.net/wiki/SC2031 -- profdatas was modified in a subsh... https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around vari... ---------- You can address the above issues in one of three ways: 1. Manually correct the issue in the offending shell script; 2. Disable specific issues by adding the comment: # shellcheck disable=NNNN above the line that contains the issue, where NNNN is the error code; 3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file. ``` </details> <details> <summary>shfmt errors</summary> ``` 'shfmt ' returned error 1 finding the following formatting issues: ---------- --- env.sh.orig +++ env.sh @@ -147,13 +147,13 @@ covs=() tmp_file=$(mktemp) - find "${DORIS_CLANG_HOME}" -name "llvm-cov*" > "${tmp_file}" + find "${DORIS_CLANG_HOME}" -name "llvm-cov*" >"${tmp_file}" # Read lines from the temporary file and populate the array while IFS= read -r line; do covs+=("$line") - done < "${tmp_file}" - + done <"${tmp_file}" + if [[ ${#covs[@]} -ge 1 ]]; then LLVM_COV="${covs[0]}" else ---------- You can reformat the above files to meet shfmt's requirements by typing: shfmt -w filename ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org