[doris] 02/03: [fix](view) The parameter positions of timestamp diff function to sql are reversed (#23601)

[kxiao]

This is an automated email from the ASF dual-hosted git repository.

kxiao pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git

commit 89736fe9372dc5f7dcff31224a741bbde8efacdb
Author: morrySnow <101034200+morrys...@users.noreply.github.com>
AuthorDate: Tue Aug 29 18:30:16 2023 +0800

    [fix](view) The parameter positions of timestamp diff function to sql are 
reversed (#23601)
---
 .../main/java/org/apache/doris/analysis/FunctionCallExpr.java  |  4 ++--
 regression-test/data/view_p0/view_p0.out                       |  3 +++
 regression-test/suites/view_p0/view_p0.groovy                  | 10 ++++++++++
 3 files changed, 15 insertions(+), 2 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java 
b/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
index 17112e1f03..d361bf99b5 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
@@ -557,8 +557,8 @@ public class FunctionCallExpr extends Expr {
                 || fnName.getFunction().equalsIgnoreCase("hours_diff")
                 || fnName.getFunction().equalsIgnoreCase("minutes_diff")
                 || fnName.getFunction().equalsIgnoreCase("seconds_diff")) {
-            sb.append(children.get(1).toSql()).append(", ");
-            sb.append(children.get(0).toSql()).append(")");
+            sb.append(children.get(0).toSql()).append(", ");
+            sb.append(children.get(1).toSql()).append(")");
             return sb.toString();
         }
         // used by nereids END
diff --git a/regression-test/data/view_p0/view_p0.out 
b/regression-test/data/view_p0/view_p0.out
index a90e1f9623..ff952fdaa7 100644
--- a/regression-test/data/view_p0/view_p0.out
+++ b/regression-test/data/view_p0/view_p0.out
@@ -12,3 +12,6 @@
 1      2023-08-01      DORID_FIELD1    DORID_FIELD2    ["cat", "dog"]  cat
 1      2023-08-01      DORID_FIELD1    DORID_FIELD2    ["cat", "dog"]  dog
 
+-- !sql --
+960
+
diff --git a/regression-test/suites/view_p0/view_p0.groovy 
b/regression-test/suites/view_p0/view_p0.groovy
index 6873c804bd..963760276b 100644
--- a/regression-test/suites/view_p0/view_p0.groovy
+++ b/regression-test/suites/view_p0/view_p0.groovy
@@ -112,5 +112,15 @@ suite("view_p0") {
         ) c;
     """
     qt_sql "select * from test_element_at_view;"
+
+    sql "drop view if exists test_element_at_view"
+
+    sql "drop view if exists test_time_diff"
+
+    sql "create view test_time_diff as select minutes_diff('2023-01-16 
10:05:04', '2023-01-15 18:05:04')"
+
+    qt_sql "select * from test_time_diff"
+
+    sql "drop view if exists test_time_diff"
     
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org