zhiqiang-hhhh commented on code in PR #23582:
URL: https://github.com/apache/doris/pull/23582#discussion_r1308118609


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -477,6 +478,20 @@ public class Env {
 
     private HiveTransactionMgr hiveTransactionMgr;
 
+    public List<TFrontendInfo> getFrontendInfos() {
+        List<TFrontendInfo> res = new ArrayList<>();
+
+        for (Frontend fe : frontends.values()) {
+            TFrontendInfo feInfo = new TFrontendInfo();
+            // TODO(zhiqiang): Choose a right address
+            feInfo.setNetworkAddress(new TNetworkAddress(fe.getHost(), 
fe.getRpcPort()));

Review Comment:
   > the address should be equal to the coordinator address in BE
   
   it is equal. Coordinator.java:525: `coordAddress = new 
TNetworkAddress(localIP, Config.rpc_port);`, i will remove the outdated TODO.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to