Astralidea commented on pull request #4504: URL: https://github.com/apache/incubator-doris/pull/4504#issuecomment-687249565
> > > @Astralidea Good job!. Please add a UT. > > > > > > 好的。UT我之前看了一下，貌似不太好加，我得想想怎么加。 > > 或许可以把你的逻辑加到SelectStmt 的 analyze 方法里面，这样 SelectStmtTest 就可以直接测试，确认session 变量是否生效。 > > 不过需要注意 context.getSessionVariable().toThrift() 要在 SelectStmt.analyze(analyzer) 之后，你可以试下。 我改写一下DorisAssert框架可以测了。 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
