morningman commented on a change in pull request #4526:
URL: https://github.com/apache/incubator-doris/pull/4526#discussion_r482805850
##########
File path: be/src/olap/rowset/segment_group.cpp
##########
@@ -258,32 +258,45 @@ OLAPStatus
SegmentGroup::add_zone_maps_for_linked_schema_change(
for (size_t i = 0; i < zonemap_col_num; ++i) {
- // in duplicated table update from 0.11 to 0.12, zone map index may be
missed
+ // in duplicated table update from 0.11 to 0.12, zone map index may be
missed and may not a new column.
if (_schema->keys_type() == DUP_KEYS &&
schema_mapping[i].ref_column != -1 &&
schema_mapping[i].ref_column >= zone_map_fields.size()) {
- continue;
+ break; // _zone_maps follows _schema column index
Review comment:
Better to add some comment to explain why break here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
