HappenLee commented on code in PR #23236:
URL: https://github.com/apache/doris/pull/23236#discussion_r1305466325


##########
be/src/exec/tablet_info.cpp:
##########
@@ -271,60 +283,14 @@ Status VOlapTablePartitionParam::init() {
         };
     }
 
-    DCHECK(!_t_param.partitions.empty()) << "must have at least 1 partition";
-    _is_in_partition = _t_param.partitions[0].__isset.in_keys;
+    // empty for auto partition table. checked in caller.
+    _is_in_partition = _t_param.partitions.empty() ? false : 
_t_param.partitions[0].__isset.in_keys;

Review Comment:
   if in_partition empty(), the check way is not right



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to