dataroaring commented on code in PR #23283:
URL: https://github.com/apache/doris/pull/23283#discussion_r1301514053
##########
be/src/service/internal_service.cpp:
##########
@@ -693,8 +693,9 @@ void PInternalServiceImpl::_get_column_ids_by_tablet_ids(
// check schema consistency, column ids should be the same
const auto& columns = tablet->tablet_schema()->columns();
std::vector<int32_t> column_ids(columns.size());
- std::transform(columns.begin(), columns.end(), column_ids.begin(),
- [](const TabletColumn& c) { return c.unique_id();
});
+ for (const auto& col : columns) {
+ column_ids.push_back(col.unique_id());
+ }
Review Comment:
Column_ids should be type of set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
