bobhan1 commented on code in PR #23228:
URL: https://github.com/apache/doris/pull/23228#discussion_r1301139961
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableStmt.java:
##########
@@ -519,19 +517,23 @@ public void analyze(Analyzer analyzer) throws
UserException, AnalysisException {
}
if (columnDef.getType().isObjectStored()) {
- hasObjectStored = true;
- objectStoredColumn = columnDef.getName();
+ if (columnDef.getType().isBitmapType()) {
+ if (keysDesc.getKeysType() == KeysType.DUP_KEYS) {
+ throw new AnalysisException("column:" +
columnDef.getName()
+ + " must be used in AGG_KEYS or UNIQUE_KEYS.");
+ }
+ } else {
+ if (keysDesc.getKeysType() != KeysType.AGG_KEYS) {
+ throw new AnalysisException("column:" +
columnDef.getName() + " must be used in AGG_KEYS.");
+ }
+ }
}
Review Comment:
> This pr also changed the behavior of hll and quantile_state, should make
corresponding changes to their documents, and add case
the behavior of hll and quantile_state is not changed, only bitmap type is
allowed to appear in unique table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
