morrySnow commented on code in PR #23249:
URL: https://github.com/apache/doris/pull/23249#discussion_r1300856712


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionUtil.java:
##########
@@ -234,8 +239,11 @@ public static boolean translateToNereids(String dbName, 
Function function) {
                 JavaUdaf.translateToNereidsFunction(dbName, 
((AggregateFunction) function));
             }
         } catch (Exception e) {
-            LOG.warn("Nereids create function {}:{} failed", dbName, 
function.getFunctionName().getFunction(), e);
+            LOG.warn("Nereids create function {}:{} failed, caused by: {}", 
dbName == null ? "_global_" : dbName,
+                    function.getFunctionName().getFunction(), e);
         }
+        LOG.info(String.format("Nereids add function: %s:%s OK!", dbName == 
null ? "_global_" : dbName,
+                function.getFunctionName().getFunction()));

Review Comment:
   remove this log



##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionUtil.java:
##########
@@ -246,8 +254,11 @@ public static boolean dropFromNereids(String dbName, 
FunctionSearchDesc function
                     .collect(Collectors.toList());
             Env.getCurrentEnv().getFunctionRegistry().dropUdf(dbName, fnName, 
argTypes);
         } catch (Exception e) {
-            LOG.warn("Nereids drop function {}:{} failed", dbName, 
function.getName(), e);
+            LOG.warn("Nereids drop function {}:{} failed, caused by: {}", 
dbName == null ? "_global_" : dbName,
+                    function.getName(), e);
         }
+        LOG.info(String.format("Nereids drop function: %s:%s OK!", dbName == 
null ? "_global_" : dbName,
+                function.getName()));

Review Comment:
   remove this log



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to