Jibing-Li commented on code in PR #23221:
URL: https://github.com/apache/doris/pull/23221#discussion_r1299572342
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalCatalogRelation.java:
##########
@@ -97,13 +98,19 @@ public List<String> getQualifier() {
* Full qualified name parts, i.e., concat qualifier and name into a list.
*/
public List<String> qualified() {
+ if (qualifier.size() == 3) {
+ return qualifier;
+ }
return Utils.qualifiedNameParts(qualifier, table.getName());
}
/**
* Full qualified table name, concat qualifier and name with `.` as
separator.
*/
public String qualifiedName() {
+ if (qualifier.size() == 3) {
Review Comment:
qualifier may only contain db name or contain full name
(catalog.db.table)，for the first case, need to concat the table name here, for
the latter case, we don't need to.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalCatalogRelation.java:
##########
@@ -97,13 +98,19 @@ public List<String> getQualifier() {
* Full qualified name parts, i.e., concat qualifier and name into a list.
*/
public List<String> qualified() {
+ if (qualifier.size() == 3) {
+ return qualifier;
+ }
return Utils.qualifiedNameParts(qualifier, table.getName());
}
/**
* Full qualified table name, concat qualifier and name with `.` as
separator.
*/
public String qualifiedName() {
+ if (qualifier.size() == 3) {
Review Comment:
qualifier may only contain db name or contain full name
(catalog.db.table)，for the first case, need to concat the table name here, for
the latter case, we don't need to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
