HappenLee commented on code in PR #23172:
URL: https://github.com/apache/doris/pull/23172#discussion_r1299145114
##########
be/src/vec/aggregate_functions/aggregate_function_bitmap.h:
##########
@@ -146,10 +146,127 @@ struct AggregateFunctionBitmapData {
BitmapValue& get() { return value; }
};
+template <typename Data, typename Derived>
+class AggregateFunctionBitmapSerializationHelper
+ : public IAggregateFunctionDataHelper<Data, Derived> {
+public:
+ using BaseHelper = IAggregateFunctionHelper<Derived>;
+
+ AggregateFunctionBitmapSerializationHelper(const DataTypes&
argument_types_)
+ : IAggregateFunctionDataHelper<Data, Derived>(argument_types_) {}
+
+ void serialize_to_column(const std::vector<AggregateDataPtr>& places,
size_t offset,
+ MutableColumnPtr& dst, const size_t num_rows)
const override {
+ if (version >= 3) {
+ auto& col = assert_cast<ColumnBitmap&>(*dst);
+ col.resize(num_rows);
+ auto* data = col.get_data().data();
+ for (size_t i = 0; i != num_rows; ++i) {
+ data[i] = this->data(places[i] + offset).value;
Review Comment:
better use `std::move(this->data(places[i] + offset).value)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
