BePPPower commented on code in PR #23062:
URL: https://github.com/apache/doris/pull/23062#discussion_r1297931424


##########
regression-test/suites/external_table_p0/tvf/test_hdfs_tvf.groovy:
##########
@@ -132,6 +132,46 @@ suite("test_hdfs_tvf","external,hive,tvf,external_docker") 
{
                         "strip_outer_array" = "false",
                         "read_json_by_line" = "true") order by id; """
 
+
+           uri = "${defaultFS}" + 
"/user/doris/preinstalled_data/json_format_test/simple_object_json.json"
+            format = "json"
+            qt_json_limit """ select * from HDFS(
+                        "uri" = "${uri}",
+                        "fs.defaultFS"= "${defaultFS}",
+                        "hadoop.username" = "${hdfsUserName}",
+                        "format" = "${format}",
+                        "strip_outer_array" = "false",
+                        "read_json_by_line" = "true") order by id limit 100; 
"""
+
+           uri = "${defaultFS}" + 
"/user/doris/preinstalled_data/json_format_test/one_array_json.json"
+            format = "json"
+            qt_json_limit """ select * from HDFS(
+                        "uri" = "${uri}",
+                        "fs.defaultFS"= "${defaultFS}",
+                        "hadoop.username" = "${hdfsUserName}",
+                        "format" = "${format}",
+                        "strip_outer_array" = "true",
+                        "read_json_by_line" = "false") order by id limit 100; 
"""
+           uri = "${defaultFS}" + 
"/user/doris/preinstalled_data/json_format_test/nest_json.json"
+            format = "json"
+            qt_json_limit """ select * from HDFS(
+                        "uri" = "${uri}",
+                        "fs.defaultFS"= "${defaultFS}",
+                        "hadoop.username" = "${hdfsUserName}",
+                        "format" = "${format}",
+                        "strip_outer_array" = "false",
+                        "read_json_by_line" = "true") order by no  limit 100; 
"""
+           uri = "${defaultFS}" + 
"/user/doris/preinstalled_data/json_format_test/nest_json.json"
+            format = "json"
+            qt_json_limit """ select * from HDFS(
+                        "uri" = "${uri}",

Review Comment:
   ```suggestion
               qt_json_limit """ select * from HDFS(
                           "uri" = "${uri}",
                           "fs.defaultFS"= "${defaultFS}",
                           "hadoop.username" = "${hdfsUserName}",
                           "format" = "${format}",
                           "strip_outer_array" = "false",
                           "read_json_by_line" = "true") order by id limit 100; 
"""
   
              uri = "${defaultFS}" + 
"/user/doris/preinstalled_data/json_format_test/one_array_json.json"
               format = "json"
               qt_json_limit1 """ select * from HDFS(
                           "uri" = "${uri}",
                           "fs.defaultFS"= "${defaultFS}",
                           "hadoop.username" = "${hdfsUserName}",
                           "format" = "${format}",
                           "strip_outer_array" = "true",
                           "read_json_by_line" = "false") order by id limit 
100; """
              uri = "${defaultFS}" + 
"/user/doris/preinstalled_data/json_format_test/nest_json.json"
               format = "json"
               qt_json_limit2 """ select * from HDFS(
                           "uri" = "${uri}",
                           "fs.defaultFS"= "${defaultFS}",
                           "hadoop.username" = "${hdfsUserName}",
                           "format" = "${format}",
                           "strip_outer_array" = "false",
                           "read_json_by_line" = "true") order by no  limit 
100; """
              uri = "${defaultFS}" + 
"/user/doris/preinstalled_data/json_format_test/nest_json.json"
               format = "json"
               qt_json_limit3 """ select * from HDFS(
                           "uri" = "${uri}",
   ```
   We should use different qt action names, so that when the data does not 
match, we can quickly locate which case it is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to