[GitHub] [doris] yiguolei commented on a diff in pull request #23019: [refactor](load) use smart pointers to manage writers in memtable memory limiter

[via GitHub]

yiguolei commented on code in PR #23019:
URL: https://github.com/apache/doris/pull/23019#discussion_r1295277733


##########
be/src/olap/delta_writer.cpp:
##########
@@ -66,7 +66,7 @@ DeltaWriter::DeltaWriter(WriteRequest* req, StorageEngine* 
storage_engine, Runti
                          const UniqueId& load_id)
         : _req(*req),
           _rowset_builder(*req, storage_engine, profile),
-          _memtable_writer(*req, profile),
+          _memtable_writer(new MemTableWriter(*req, profile)),

Review Comment:
   这里有一个问题，就是这个profile，虽然memtable writer 是一个shared ptr，可以再 
mmemtable_memory_limiter 中lock 一下，但是假如delta writer 推出了，那么profile 
这个指针关联的对象可能也没有了；但是 memtablewriter 依赖了profile，那么在memtable memory limiter 
那个线程中，就可能挂掉。
   可能我们需要把load channel 这里的profile 改成shared ptr



##########
be/src/olap/delta_writer.cpp:
##########
@@ -66,7 +66,7 @@ DeltaWriter::DeltaWriter(WriteRequest* req, StorageEngine* 
storage_engine, Runti
                          const UniqueId& load_id)
         : _req(*req),
           _rowset_builder(*req, storage_engine, profile),
-          _memtable_writer(*req, profile),
+          _memtable_writer(new MemTableWriter(*req, profile)),

Review Comment:
   这里有一个问题，就是这个profile，虽然memtable writer 是一个shared ptr，可以再 
mmemtable_memory_limiter 中lock 一下，但是假如delta writer 推出了，那么profile 
这个指针关联的对象可能也没有了；但是 memtablewriter 依赖了profile，那么在memtable memory limiter 
那个线程中，就可能挂掉。
   可能我们需要把load channel 这里的profile 改成shared ptr



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org