morningman commented on code in PR #22923:
URL: https://github.com/apache/doris/pull/22923#discussion_r1293219304
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/iceberg/IcebergScanNode.java:
##########
@@ -334,4 +349,41 @@ public TableIf getTargetTable() {
public Map<String, String> getLocationProperties() throws UserException {
return source.getCatalog().getProperties();
}
+
+ @Override
+ public boolean pushDownAggNoGrouping(FunctionCallExpr aggExpr) {
+ String aggFunctionName =
aggExpr.getFnName().getFunction().toUpperCase();
+ return "COUNT".equals(aggFunctionName);
+ }
+
+ @Override
+ public boolean pushDownAggNoGroupingCheckCol(FunctionCallExpr aggExpr,
Column col) {
+ return !col.isAllowNull();
+ }
+
+ private long getCountFromSnapshot() {
+ Snapshot snapshot = icebergTable.currentSnapshot();
Review Comment:
Every time to call this `getCountFromSnapshot`, it will return the `current
snapshot` of this table. And different call may get different snapshots.
BTW, we support time travel query of iceberg, how to handle it, eg:
`select from iceberg of timestamp xxxx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
