morningman commented on code in PR #22899:
URL: https://github.com/apache/doris/pull/22899#discussion_r1291355433
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/paimon/PaimonValueConverter.java:
##########
@@ -110,11 +121,15 @@ public Long visit(BigIntType bigIntType) {
return null;
}
+ // when a = 9.1,paimon can get data,doris can not get data
+ // when a > 9.1,paimon can not get data,doris can get data
+ // paimon is no problem,but we consistent with Doris internal table
+ // Therefore, comment out this code
public Float visit(FloatType floatType) {
- if (expr instanceof FloatLiteral) {
- FloatLiteral floatLiteral = (FloatLiteral) expr;
- return (float) floatLiteral.getValue();
- }
+ // if (expr instanceof FloatLiteral) {
Review Comment:
remove unused code
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/paimon/PaimonValueConverter.java:
##########
@@ -127,39 +142,25 @@ public Double visit(DoubleType doubleType) {
}
public Object visit(DateType dateType) {
+ if (expr instanceof DateLiteral) {
+ DateLiteral dateLiteral = (DateLiteral) expr;
+ dateLiteral.getLongValue();
Review Comment:
usused code?
##########
fe/be-java-extensions/paimon-scanner/src/main/java/org/apache/doris/paimon/PaimonColumnValue.java:
##########
@@ -109,14 +109,13 @@ public byte[] getStringAsBytes() {
@Override
public LocalDate getDate() {
- return Instant.ofEpochMilli(record.getTimestamp(idx, 3)
- .getMillisecond()).atZone(ZoneOffset.ofHours(8)).toLocalDate();
+ return LocalDate.ofEpochDay(record.getLong(idx));
}
@Override
public LocalDateTime getDateTime() {
return Instant.ofEpochMilli(record.getTimestamp(idx, 3)
- .getMillisecond()).atZone(ZoneOffset.ofHours(8)).toLocalDateTime();
+ .getMillisecond()).atZone(ZoneOffset.ofHours(0)).toLocalDateTime();
Review Comment:
Why changing to zero?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
