kangkaisen commented on a change in pull request #4330:
URL: https://github.com/apache/incubator-doris/pull/4330#discussion_r473564840
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
##########
@@ -575,6 +583,78 @@ private void handleSetStmt() {
context.getState().setOk();
}
+ private void sendChannel(MysqlChannel channel, List<CacheProxy.CacheValue>
cacheValues, boolean hitAll)
Review comment:
I think `sendChannel ` shouldn't know query cache hit logic. which only
to know how to send and when finish.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
