morningman commented on a change in pull request #4383:
URL: https://github.com/apache/incubator-doris/pull/4383#discussion_r473516074
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -543,6 +543,15 @@
@ConfField
public static String spark_resource_path = "";
+ /**
+ * Default yarn client path
+ */
+ @ConfField(mutable = true, masterOnly = true)
Review comment:
immutable
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkEtlJobHandler.java
##########
@@ -262,19 +273,22 @@ public EtlStatus getEtlJobStatus(SparkAppHandle handle,
String appId, long loadJ
return status;
}
- public void killEtlJob(SparkAppHandle handle, String appId, long
loadJobId, SparkResource resource) {
+ public void killEtlJob(SparkAppHandle handle, String appId, long
loadJobId, SparkResource resource) throws LoadException {
if (resource.isYarnMaster()) {
Preconditions.checkNotNull(appId);
- YarnClient client = startYarnClient(resource);
- try {
- try {
-
client.killApplication(ConverterUtils.toApplicationId(appId));
- LOG.info("yarn application -kill {}", appId);
- } catch (YarnException | IOException e) {
- LOG.warn("yarn application kill failed. app id: {}, load
job id: {}", appId, loadJobId, e);
- }
- } finally {
- stopYarnClient(client);
+ // prepare yarn config
+ String configDir = resource.prepareYarnConfig();
+ // yarn client path
+ String yarnClient = Config.yarn_client_path;
Review comment:
Better to create a function called `getYarnClienthPath()` and check if
the binary file exist in that function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
