HappenLee commented on code in PR #22823:
URL: https://github.com/apache/doris/pull/22823#discussion_r1290840695
##########
be/src/vec/functions/if.cpp:
##########
@@ -480,9 +480,8 @@ class FunctionIf : public IFunction {
Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
size_t result, size_t input_rows_count) override {
- const ColumnWithTypeAndName& arg_then =
block.get_by_position(arguments[1]);
- const ColumnWithTypeAndName& arg_else =
block.get_by_position(arguments[2]);
-
+ ColumnWithTypeAndName arg_then = block.get_by_position(arguments[1]);
Review Comment:
here maybe a copy ？
##########
be/src/vec/functions/if.cpp:
##########
@@ -480,9 +480,8 @@ class FunctionIf : public IFunction {
Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
size_t result, size_t input_rows_count) override {
- const ColumnWithTypeAndName& arg_then =
block.get_by_position(arguments[1]);
- const ColumnWithTypeAndName& arg_else =
block.get_by_position(arguments[2]);
-
+ ColumnWithTypeAndName arg_then = block.get_by_position(arguments[1]);
Review Comment:
here maybe a copy ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
