hubgeter commented on code in PR #22702:
URL: https://github.com/apache/doris/pull/22702#discussion_r1290465500
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/SchemaTable.java:
##########
@@ -379,37 +379,65 @@ public class SchemaTable extends Table {
.column("COLLATION_CONNECTION",
ScalarType.createVarchar(32))
.column("DATABASE_COLLATION",
ScalarType.createVarchar(32)).build()))
.put("rowsets", new SchemaTable(SystemIdGenerator.getNextId(),
"rowsets", TableType.SCHEMA,
- builder().column("BACKEND_ID",
ScalarType.createType(PrimitiveType.BIGINT))
- .column("ROWSET_ID",
ScalarType.createVarchar(64))
- .column("TABLET_ID",
ScalarType.createType(PrimitiveType.BIGINT))
- .column("ROWSET_NUM_ROWS",
ScalarType.createType(PrimitiveType.BIGINT))
- .column("TXN_ID",
ScalarType.createType(PrimitiveType.BIGINT))
- .column("NUM_SEGMENTS",
ScalarType.createType(PrimitiveType.BIGINT))
- .column("START_VERSION",
ScalarType.createType(PrimitiveType.BIGINT))
- .column("END_VERSION",
ScalarType.createType(PrimitiveType.BIGINT))
- .column("INDEX_DISK_SIZE",
ScalarType.createType(PrimitiveType.BIGINT))
- .column("DATA_DISK_SIZE",
ScalarType.createType(PrimitiveType.BIGINT))
- .column("CREATION_TIME",
ScalarType.createType(PrimitiveType.BIGINT))
- .column("NEWEST_WRITE_TIMESTAMP",
ScalarType.createType(PrimitiveType.BIGINT))
- .build()))
+ builder().column("BACKEND_ID",
ScalarType.createType(PrimitiveType.BIGINT))
+ .column("ROWSET_ID", ScalarType.createVarchar(64))
+ .column("TABLET_ID",
ScalarType.createType(PrimitiveType.BIGINT))
+ .column("ROWSET_NUM_ROWS",
ScalarType.createType(PrimitiveType.BIGINT))
+ .column("TXN_ID",
ScalarType.createType(PrimitiveType.BIGINT))
+ .column("NUM_SEGMENTS",
ScalarType.createType(PrimitiveType.BIGINT))
+ .column("START_VERSION",
ScalarType.createType(PrimitiveType.BIGINT))
+ .column("END_VERSION",
ScalarType.createType(PrimitiveType.BIGINT))
+ .column("INDEX_DISK_SIZE",
ScalarType.createType(PrimitiveType.BIGINT))
+ .column("DATA_DISK_SIZE",
ScalarType.createType(PrimitiveType.BIGINT))
+ .column("CREATION_TIME",
ScalarType.createType(PrimitiveType.BIGINT))
+ .column("NEWEST_WRITE_TIMESTAMP",
ScalarType.createType(PrimitiveType.BIGINT))
+ .build()))
.put("parameters", new SchemaTable(SystemIdGenerator.getNextId(),
"parameters", TableType.SCHEMA,
- builder().column("SPECIFIC_CATALOG",
ScalarType.createVarchar(64))
- .column("SPECIFIC_SCHEMA",
ScalarType.createVarchar(64))
- .column("SPECIFIC_NAME",
ScalarType.createVarchar(64))
- .column("ORDINAL_POSITION",
ScalarType.createVarchar(77))
- .column("PARAMETER_MODE",
ScalarType.createVarchar(77))
- .column("PARAMETER_NAME",
ScalarType.createVarchar(77))
- .column("DATA_TYPE",
ScalarType.createVarchar(64))
- .column("CHARACTER_OCTET_LENGTH",
ScalarType.createVarchar(64))
- .column("NUMERIC_PRECISION",
ScalarType.createVarchar(512))
- .column("NUMERIC_SCALE",
ScalarType.createVarchar(64))
- .column("DATETIME_PRECISION",
ScalarType.createVarchar(64))
- .column("CHARACTER_SET_NAME",
ScalarType.createVarchar(256))
- .column("COLLATION_NAME",
ScalarType.createVarchar(64))
- .column("DTD_IDENTIFIER",
ScalarType.createVarchar(64))
- .column("ROUTINE_TYPE",
ScalarType.createVarchar(64))
- .column("DATA_TYPEDTD_IDENDS",
ScalarType.createVarchar(64))
- .build()))
+ builder().column("SPECIFIC_CATALOG",
ScalarType.createVarchar(64))
+ .column("SPECIFIC_SCHEMA",
ScalarType.createVarchar(64))
+ .column("SPECIFIC_NAME",
ScalarType.createVarchar(64))
+ .column("ORDINAL_POSITION",
ScalarType.createVarchar(77))
+ .column("PARAMETER_MODE",
ScalarType.createVarchar(77))
+ .column("PARAMETER_NAME",
ScalarType.createVarchar(77))
+ .column("DATA_TYPE", ScalarType.createVarchar(64))
+ .column("CHARACTER_OCTET_LENGTH",
ScalarType.createVarchar(64))
+ .column("NUMERIC_PRECISION",
ScalarType.createVarchar(512))
+ .column("NUMERIC_SCALE",
ScalarType.createVarchar(64))
+ .column("DATETIME_PRECISION",
ScalarType.createVarchar(64))
+ .column("CHARACTER_SET_NAME",
ScalarType.createVarchar(256))
+ .column("COLLATION_NAME",
ScalarType.createVarchar(64))
+ .column("DTD_IDENTIFIER",
ScalarType.createVarchar(64))
+ .column("ROUTINE_TYPE",
ScalarType.createVarchar(64))
+ .column("DATA_TYPEDTD_IDENDS",
ScalarType.createVarchar(64))
+ .build()))
+ .put("simple_tables", new
SchemaTable(SystemIdGenerator.getNextId(), "simple_tables", TableType.SCHEMA,
Review Comment:
ok good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
