[GitHub] [doris] morningman commented on a diff in pull request #22554: [improvement](create partition) create partition require quorum replicas succ

[via GitHub]

morningman commented on code in PR #22554:
URL: https://github.com/apache/doris/pull/22554#discussion_r1290313332


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -1868,10 +1868,19 @@ private Partition createPartitionWithIndices(String 
clusterName, long dbId, long
             }
 
             if (!ok || !countDownLatch.getStatus().ok()) {
-                errMsg = "Failed to create partition[" + partitionName + "].";
                 // clear tasks
                 AgentTaskQueue.removeBatchTask(batchTask, TTaskType.CREATE);
 
+                int quorumReplicaNum = totalReplicaNum / 2 + 1;

Review Comment:
   We should check the quorum of each tablet, not the quorum of total replicas



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org