zhannngchen commented on code in PR #22566:
URL: https://github.com/apache/doris/pull/22566#discussion_r1288187978
##########
be/src/olap/delete_bitmap_calculator.h:
##########
@@ -82,31 +97,41 @@ class MergeIndexDeleteBitmapCalculatorContext {
size_t _cur_row_id {0};
size_t const _num_rows;
size_t const _max_batch_size;
+ size_t const _end_version;
+ bool const _base_segment;
+ RowsetId const _rowset_id;
int32_t const _segment_id;
- bool _excat_match {false};
+ bool _excat_match;
};
-class MergeIndexDeleteBitmapCalculator {
+class MergedPKIndexDeleteBitmapCalculator {
public:
- MergeIndexDeleteBitmapCalculator() = default;
-
- Status init(RowsetId rowset_id, std::vector<SegmentSharedPtr> const&
segments,
- size_t seq_col_length = 0, size_t max_batch_size = 1024);
+ MergedPKIndexDeleteBitmapCalculator() = default;
- Status calculate_one(RowLocation& loc);
+ Status init(std::vector<SegmentSharedPtr> const& segments,
Review Comment:
There's 2 ways of using `MergedPKIndexDeleteBitmapCalculator`, you need to
explain how to use it for these 2 ways in comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
