BePPPower commented on code in PR #22707:
URL: https://github.com/apache/doris/pull/22707#discussion_r1286642251


##########
fe/fe-core/src/main/java/org/apache/doris/scheduler/manager/AsyncJobManager.java:
##########
@@ -156,19 +156,20 @@ private void initAndSchedulerJob(Job job) {
     }
 
     private Long findFistExecuteTime(Long currentTimeMs, Long startTimeMs, 
Long intervalMs, boolean isCycleJob) {
+        // if job not delay, first execute time is start time
         if (startTimeMs != 0L && startTimeMs > currentTimeMs) {
             return startTimeMs;
         }
-        // if it's not cycle job and already delay, next execute time is 
current time
-        if (!isCycleJob) {
+        // if job already delay, first execute time is current time
+        if (startTimeMs != 0L && startTimeMs < currentTimeMs) {
             return currentTimeMs;
         }

Review Comment:
   if starTime = 7, interval = 2, currentTime = 8:
   user may hope the next execute time is 9 (7+2), rather than 8.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to