morrySnow commented on code in PR #22550: URL: https://github.com/apache/doris/pull/22550#discussion_r1285571285
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/EliminateSort.java: ########## @@ -0,0 +1,87 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.rewrite; + +import org.apache.doris.nereids.jobs.JobContext; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.trees.plans.logical.LogicalProject; +import org.apache.doris.nereids.trees.plans.logical.LogicalSink; +import org.apache.doris.nereids.trees.plans.logical.LogicalSort; +import org.apache.doris.nereids.trees.plans.visitor.CustomRewriter; +import org.apache.doris.nereids.trees.plans.visitor.DefaultPlanRewriter; + +import java.util.ArrayList; +import java.util.List; + +/** + * Eliminate sort that is not directly below result sink + * Note we have put limit in sort node so that we don't need to consider limit + */ + +public class EliminateSort extends DefaultPlanRewriter<Boolean> implements CustomRewriter { + @Override + public Plan rewriteRoot(Plan plan, JobContext jobContext) { + Boolean eliminateSort = false; + return plan.accept(this, eliminateSort); + } + + @Override + public Plan visit(Plan plan, Boolean pruneSort) { + List<Plan> newChildren = new ArrayList<>(); + boolean hasNewChildren = false; + for (Plan child : plan.children()) { + Plan newChild = child.accept(this, true); + if (newChild != child) { + hasNewChildren = true; + } + newChildren.add(newChild); + } + return hasNewChildren ? plan.withChildren(newChildren) : plan; + } + + @Override + public Plan visitLogicalSort(LogicalSort<? extends Plan> sort, Boolean eliminateSort) { + if (eliminateSort) { + return sort.child(); + } + return sort; Review Comment: should visit its child -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
