HappenLee commented on code in PR #22600:
URL: https://github.com/apache/doris/pull/22600#discussion_r1285001960
##########
be/src/service/internal_service.cpp:
##########
@@ -983,7 +983,14 @@ void
PInternalServiceImpl::transmit_block(google::protobuf::RpcController* contr
google::protobuf::Closure* done) {
int64_t receive_time = GetCurrentTimeNanos();
response->set_receive_time(receive_time);
- PriorityThreadPool& pool = request->has_block() ? _heavy_work_pool :
_light_work_pool;
+
+ if (!request->has_block() && config::brpc_light_work_pool_threads == -1) {
Review Comment:
in which case？the config::brpc_light_work_pool_threads == -1？
##########
be/src/service/internal_service.cpp:
##########
@@ -983,7 +983,14 @@ void
PInternalServiceImpl::transmit_block(google::protobuf::RpcController* contr
google::protobuf::Closure* done) {
int64_t receive_time = GetCurrentTimeNanos();
response->set_receive_time(receive_time);
- PriorityThreadPool& pool = request->has_block() ? _heavy_work_pool :
_light_work_pool;
+
+ if (!request->has_block() && config::brpc_light_work_pool_threads == -1) {
Review Comment:
in which case？the config::brpc_light_work_pool_threads == -1？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
