WingsGo edited a comment on pull request #4350: URL: https://github.com/apache/incubator-doris/pull/4350#issuecomment-673929122
For reviewers, I found that ORC include file didn't expose orc::TimezoneError, which is writer in Timezone.hh, I don't know why, maybe it is a wrong design, I will submit a issue to ORC project, currently solution is declare `orc::TimezoneError` by handle or just catch `std::runtime_error` exception, I choosen the first solution because I think it is less error-prone and more reasonable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
