freemandealer commented on code in PR #22577: URL: https://github.com/apache/doris/pull/22577#discussion_r1284065626
########## be/src/runtime/load_channel_mgr.cpp: ########## @@ -169,6 +169,10 @@ Status LoadChannelMgr::add_batch(const PTabletWriterAddBlockRequest& request, // this case will be handled in load channel's add batch method. Status st = channel->add_batch(request, response); if (UNLIKELY(!st.ok())) { + { + std::lock_guard<std::mutex> l(_lock); Review Comment: unreasonable lock -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org