yiguolei commented on code in PR #22602: URL: https://github.com/apache/doris/pull/22602#discussion_r1284016243
########## be/src/vec/functions/function_timestamp.cpp: ########## @@ -423,10 +423,12 @@ struct DateTrunc { const StringRef& rdata, PaddedPODArray<ArgType>& res, NullMap& null_map, size_t input_rows_count) { res.resize(input_rows_count); + std::string lower_str(rdata.data, rdata.size); Review Comment: add regression test please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org