zhannngchen commented on code in PR #22282: URL: https://github.com/apache/doris/pull/22282#discussion_r1282600640
########## be/src/olap/tablet.cpp: ########## @@ -3318,6 +3332,12 @@ Status Tablet::update_delete_bitmap(const RowsetSharedPtr& rowset, << ", cur max_version: " << cur_version << ", transaction_id: " << txn_id << ", cost: " << watch.get_elapse_time_us() << "(us), total rows: " << total_rows; + if (do_correctness_check) { + // check if all the rowset has ROWSET_SENTINEL_MARK + RETURN_IF_ERROR(check_delete_bitmap_correctness(delete_bitmap, cur_version - 1)); Review Comment: consider reuse the variable `cur_rowset_ids`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org