xingyingone opened a new issue, #22518:
URL: https://github.com/apache/doris/issues/22518

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Description
   
   我对streaming_agg_serialize_to_column函数的实现有些疑问:
   1)是不是对columns[0]->is_nullable()重复判断了。如果是重复判断,那可以精简一下判断逻辑
   2)后面两个判断是不是应该对value进行判断,即应该是columns[1]->is_nullable()。
   
   ### Solution
   
   精简下判断或者改成对columns[1]进行判断。我继续看下代码,也希望有大佬指导我一下,我有兴趣继续跟进下去。
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to