This is an automated email from the ASF dual-hosted git repository.

morrysnow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 527782f3d3 [fix](nereids)move RecomputeLogicalPropertiesProcessor rule 
before topn optimization (#22488)
527782f3d3 is described below

commit 527782f3d38817178732c6d109cafd87535381fe
Author: starocean999 <40539150+starocean...@users.noreply.github.com>
AuthorDate: Wed Aug 2 17:36:56 2023 +0800

    [fix](nereids)move RecomputeLogicalPropertiesProcessor rule before topn 
optimization (#22488)
    
    topn optimization will change MutableState. So need move 
RecomputeLogicalPropertiesProcessor rule before it
---
 .../org/apache/doris/nereids/processor/post/PlanPostProcessors.java   | 2 +-
 .../org/apache/doris/nereids/postprocess/TopNRuntimeFilterTest.java   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/PlanPostProcessors.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/PlanPostProcessors.java
index 3b47fb4b5d..40891e82a4 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/PlanPostProcessors.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/PlanPostProcessors.java
@@ -69,9 +69,9 @@ public class PlanPostProcessors {
             }
         }
         builder.add(new Validator());
+        builder.add(new RecomputeLogicalPropertiesProcessor());
         builder.add(new TopNScanOpt());
         builder.add(new TwoPhaseReadOpt());
-        builder.add(new RecomputeLogicalPropertiesProcessor());
         return builder.build();
     }
 }
diff --git 
a/fe/fe-core/src/test/java/org/apache/doris/nereids/postprocess/TopNRuntimeFilterTest.java
 
b/fe/fe-core/src/test/java/org/apache/doris/nereids/postprocess/TopNRuntimeFilterTest.java
index a3449909de..b38f4876e3 100644
--- 
a/fe/fe-core/src/test/java/org/apache/doris/nereids/postprocess/TopNRuntimeFilterTest.java
+++ 
b/fe/fe-core/src/test/java/org/apache/doris/nereids/postprocess/TopNRuntimeFilterTest.java
@@ -39,7 +39,7 @@ public class TopNRuntimeFilterTest extends SSBTestBase {
                 .rewrite()
                 .implement();
         PhysicalPlan plan = checker.getPhysicalPlan();
-        new PlanPostProcessors(checker.getCascadesContext()).process(plan);
+        plan = new 
PlanPostProcessors(checker.getCascadesContext()).process(plan);
         Assertions.assertTrue(plan.children().get(0).child(0) instanceof 
PhysicalTopN);
         PhysicalTopN localTopN = (PhysicalTopN) 
plan.children().get(0).child(0);
         
Assertions.assertTrue(localTopN.getMutableState(PhysicalTopN.TOPN_RUNTIME_FILTER).isPresent());
@@ -53,7 +53,7 @@ public class TopNRuntimeFilterTest extends SSBTestBase {
                 .rewrite()
                 .implement();
         PhysicalPlan plan = checker.getPhysicalPlan();
-        new PlanPostProcessors(checker.getCascadesContext()).process(plan);
+        plan = new 
PlanPostProcessors(checker.getCascadesContext()).process(plan);
         Assertions.assertTrue(plan.children().get(0) instanceof PhysicalTopN);
         PhysicalTopN localTopN = (PhysicalTopN) plan.children().get(0);
         
Assertions.assertFalse(localTopN.getMutableState(PhysicalTopN.TOPN_RUNTIME_FILTER).isPresent());


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to