zhangstar333 commented on code in PR #22327:
URL: https://github.com/apache/doris/pull/22327#discussion_r1281354232
##########
be/src/vec/exec/distinct_vaggregation_node.cpp:
##########
@@ -53,23 +53,23 @@ Status
DistinctAggregationNode::_distinct_pre_agg_with_serialized_key(
}
int rows = in_block->rows();
- IColumn::Selector distinct_row;
- distinct_row.reserve(rows);
+ _distinct_row.clear();
+ _distinct_row.reserve(rows);
RETURN_IF_CATCH_EXCEPTION(
- _emplace_into_hash_table_to_distinct(distinct_row, key_columns,
rows));
+ _emplace_into_hash_table_to_distinct(_distinct_row, key_columns,
rows));
Review Comment:
maybe could add those optimization on partition_sort_node hash map ,
`void VPartitionSortNode::_emplace_into_hash_table(const ColumnRawPtrs&
key_columns,`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
