HappenLee commented on code in PR #22327:
URL: https://github.com/apache/doris/pull/22327#discussion_r1278975397
##########
be/src/vec/common/columns_hashing.h:
##########
@@ -73,6 +75,14 @@ struct HashMethodOneNumber : public
columns_hashing_impl::HashMethodBase<
FieldType get_key_holder(size_t row, Arena&) const {
return unaligned_load<FieldType>(vec + row * sizeof(FieldType));
}
+
+ std::vector<FieldType> get_keys(size_t rows_number) const {
Review Comment:
std::span
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
