HappenLee commented on code in PR #22269:
URL: https://github.com/apache/doris/pull/22269#discussion_r1278864035
##########
be/src/util/date_func.cpp:
##########
@@ -118,13 +118,17 @@ int32_t time_to_buffer_from_double(double time, char*
buffer) {
int32_t timev2_to_buffer_from_double(double time, char* buffer, int scale) {
static int pow10[7] = {1, 10, 100, 1000, 10000, 100000, 1000000};
+ const static int64_t max_time = (int64_t)3020399 * 1000 * 1000;
Review Comment:
The value better be a CONST_VALUE, only define one time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
