morningman commented on code in PR #21621:
URL: https://github.com/apache/doris/pull/21621#discussion_r1278762586


##########
gensrc/thrift/FrontendService.thrift:
##########
@@ -621,6 +621,59 @@ struct TStreamLoadMultiTablePutResult {
     3: optional list<PaloInternalService.TPipelineFragmentParams> 
pipeline_params
 }
 
+// HttpLoad request, used to load a streaming to engine
+struct THttpLoadPutRequest {
+    1: required Types.TUniqueId loadId
+    2: optional string load_sql // insert into sql used by http load
+}
+
+struct THttpLoadPutResult {
+    1: required Status.TStatus status
+    2: required i64 txn_id
+    3: optional i64 total_rows
+    4: optional i64 loaded_rows
+    5: optional i64 filtered_rows
+    6: optional i64 unselected_rows
+}
+
+// httptvf properties
+struct THttpLoadPutParams {
+    1: required string db
+    2: required string table
+    3: optional string label
+    4: optional string column_separator
+    5: optional string line_delimiter
+    6: optional double max_filter_ratio
+    7: optional string where
+    8: optional string partitions
+    9: optional string temporary_partitions
+    10: optional string columns
+    11: required string format

Review Comment:
   do not use `required`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to