csun5285 commented on code in PR #22159:
URL: https://github.com/apache/doris/pull/22159#discussion_r1278307841
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -63,13 +63,16 @@ uint32_t
TimeSeriesCumulativeCompactionPolicy::calc_cumulative_compaction_score(
return 0;
}
- // Condition 1: the size of input files for compaction meets the
requirement of parameter _compaction_goal_size
- if (total_size >= (config::time_series_compaction_goal_size_mbytes * 1024
* 1024)) {
+ // Condition 1: the size of input files for compaction meets the
requirement of parameter compaction_goal_size
+ if (total_size >=
+
(tablet->tablet_meta()->tablet_schema()->time_series_compaction_goal_size_mbytes()
* 1024 *
Review Comment:
done
##########
be/src/olap/compaction.cpp:
##########
@@ -148,8 +148,10 @@ int64_t Compaction::get_avg_segment_rows() {
// input_rowsets_size is total disk_size of input_rowset, this size is the
// final size after codec and compress, so expect dest segment file size
// in disk is config::vertical_compaction_max_segment_size
- if (config::compaction_policy == CUMULATIVE_TIME_SERIES_POLICY) {
- return (config::time_series_compaction_goal_size_mbytes * 1024 * 1024
* 2) /
+ if (_tablet->tablet_meta()->tablet_schema()->compaction_policy() ==
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
