platoneko commented on code in PR #22238:
URL: https://github.com/apache/doris/pull/22238#discussion_r1277167504
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -164,7 +168,15 @@ int
TimeSeriesCumulativeCompactionPolicy::pick_input_rowsets(
input_rowsets->clear();
int64_t total_size = 0;
- for (auto& rowset : candidate_rowsets) {
+ std::vector<RowsetSharedPtr> filtered_rowsets;
Review Comment:
No need to copy rowset ptr from `candidate_rowsets` to `filtered_rowsets`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
