yiguolei commented on code in PR #22301:
URL: https://github.com/apache/doris/pull/22301#discussion_r1276132576
##########
be/src/vec/exec/scan/new_olap_scanner.cpp:
##########
@@ -130,8 +130,11 @@ Status NewOlapScanner::init() {
// batch size is passed down to segment iterator, use _state->batch_size()
// instead of _parent->limit(), because if _parent->limit() is a very small
// value (e.g. select a from t where a .. and b ... limit 1),
- // it will be very slow when reading data in segment iterator
- _tablet_reader->set_batch_size(_state->batch_size());
+ // it will be very slow when reading data with predicate in segment
iterator
+ _tablet_reader->set_batch_size(
Review Comment:
Maybe not.
conjunts maybe empty when the expr is convert to predicate.
If you do not meet an online problem or any benchmark, I think we do not
need to add this check. Because users may refactor code and we may forget this
condition. And the query maybe very slow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
